[Matroska-devel] Re: r7150 - trunk/libavformat/matroska.c

Moritz Bunkus moritz at bunkus.org
Wed Nov 22 19:23:34 CET 2006


Hey,

On Wednesday 22 November 2006 10:56, Steve Lhomme wrote:

> >> Ok, so now as you know that matroska is quite braindead, you don't even
> >> expect it to contain a proper 34 bytes extradata and normal data packets.
> >> You may at least expect that they stored the extradata prepended to
> >> the first data packet ?
> >> They managed to do even worse ! They indeed pack the extradata with the
> >> first data packet, but they store it in the extradata block !

Hmmm not really. The FLAC specs say that a STREAM consists of
METADATA_BLOCK
METADATA_BLOCK*
FRAME+

mkvmerge reads as many blocks from a FLAC file until libFLAC's
FLAC__seekable_stream_decoder_process_until_end_of_metadata returns. All
data up to that point is stored in the Matroska file's CodecPrivate ( =
extradata).

Meaning: mkvmerge should only store all metadata blocks in
CodecPrivate. If there's a real frame stored in CodecPrivate as well
then that is a bug.

Mosu

-- 
If Darl McBride was in charge, he'd probably make marriage
unconstitutional too, since clearly it de-emphasizes the commercial
nature of normal human interaction, and probably is a major impediment
to the commercial growth of prostitution. - Linus Torvalds

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.matroska.org/pipermail/matroska-devel/attachments/20061122/10c7caf9/attachment.pgp>


More information about the Matroska-devel mailing list