[Matroska-devel] Re: [ matroska-Bugs-623 ] Bug in EbmlElement::FindNextID method

Steve Lhomme steve.lhomme at free.fr
Wed Jan 25 02:13:21 CET 2006


Hi,

No this is not a bug, we support IDs of size 1, 2, 3, 4. The ++ is done 
before the test. So for that test the value start at 1 and not 0.

Thanks for paying attention :) And merry Xmas ;)

noreply at corecodec.org wrote:
> Bugs item #623, was opened at 2005-12-25 15:26
> You can respond by visiting: 
> http://corecodec.org/tracker/?func=detail&atid=269&aid=623&group_id=49
> 
> Category: libebml
> Group: None
> Status: Open
> Resolution: None
> Priority: 5
> Submitted By: Nobody (None)
> Assigned to: Steve Lhomme (robux4)
> Summary: Bug in EbmlElement::FindNextID method
> 
> Initial Comment:
> Following is current logic in EbmlElement::FindNextID method (EbmlElement.cpp, line 256, version 0.7.6)
> 
> 
> 
> binary PossibleId[4];
> 
> int PossibleID_Length = 0;
> 
> 
> 
> while (1) {
> 
>   ReadSize += DataStream.read(&PossibleId[PossibleID_Length], 1);
> 
>   if (ReadSize == uint32(PossibleID_Length)) return NULL; // no more data ?
> 
>   if (++PossibleID_Length > 4) return NULL;
> 
> }
> 
> 
> 
> I think that the statement should be:
> 
> 
> 
>   if (++PossibleID_Length >= 4) return NULL;
> 
> 
> 
> Is it right?
> 
> 
> 
> Please send me an email if you confirm it's a bug. Thanks in advance!
> 
> 
> 
> Email: nhquynh_sgt at yahoo.com
> 
> 
> 
> ----------------------------------------------------------------------
> 
> You can respond by visiting: 
> http://corecodec.org/tracker/?func=detail&atid=269&aid=623&group_id=49
> 
> 
> 

-- 
robUx4 on blog <http://robux4.blogspot.com/>



More information about the Matroska-devel mailing list