[Matroska-users] about deleting KaxBlockBlob objects
moritz at bunkus.org
Wed Nov 23 12:05:28 CET 2011
1. You seem to have reversed the direction in the same; the "source"
file is the directory named "new". The other way around would be
2. Checking for NULL before "delete pointer;" is not needed. That's in
the C++ standard. The patch for this part of the file doesn't change
the functionality at all.
3. I'm not convinced that your change is actually necessary. I use
libmatroska as it is in mkvmerge including the V2 #defines, and
mkvmerge doesn't have memory leaks that could be traced back to this
part of libmatroska. Please show me a test case.
More information about the Matroska-users